Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise latest/all behaviour for members/member-of endpoints #399

Open
alexdunnjpl opened this issue Dec 4, 2023 · 4 comments
Open

Comments

@alexdunnjpl
Copy link
Contributor

alexdunnjpl commented Dec 4, 2023

馃挕 Description

Post #396, /all and /latest endpoints still exist, but have no effect. Either restore their functionality, or remove them.

@jordanpadams I suggest we remove the endpoints, and have the members/member-of endpoints behave in the following manner:

  • products/{lid}/members return the first-level members of the latest lidvid for lid
  • products/{lid}/members/members return the second-level members of the latest lidvid for lid
  • products/{lid}/member-of get the document for the latest lidvid for lid, and return every lidvid specified in the appropriate ancestry attribute (should only ever be populated with lidvids afaik)
  • products/{lid}/member-of/member-of get the document for the latest lidvid for lid, and return every lidvid specified in the appropriate ancestry attribute (should only ever be populated with lidvids afaik)
@tloubrieu-jpl
Copy link
Member

@alexdunnjpl @jordanpadams I agree with that proposal, the most simple the better since I don't feel like supporting lid only there is important except for the fact that they are sub-path of product/{lid} which we support (as Alex just told me !)

@jordanpadams
Copy link
Member

@alexdunnjpl to clarify, do this still works?

/products/{identifier}/all
/products/{identifier}/latest

@jordanpadams
Copy link
Member

@alexdunnjpl per our discussion at the stand-up, as long as those endpoints work, those are the only ones we care about. I think the others can go away because I don't really see the use cases there.

@alexdunnjpl
Copy link
Contributor Author

alexdunnjpl commented Dec 7, 2023

@tloubrieu-jpl I'd tentatively suggest this as a candidate for my next deliverable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants