-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load positivity datasets with cuts #2058
Comments
Why? Positivity is quite special. I don't think we should e.g. not include positivity if we change the Q2 cut to above 5Gev2 if we want to test the stability for example |
I don't think cuts would apply for positivity by default (and if they do, they should be process type POS and not DIS) but we should be able to add them if needed. |
Okay, as long as it's not by default I don't see any problem |
Hi @scarlehoff, just to make sure I understand this correctly. Another options would be that of creating a new kinematics file eg for |
No. There should be no changes to
And then positivity will be cut below x = 0.1. However cuts are not applied to positivity sets.
This is what has been done for the FLL 19PTS and what I would like to avoid (with the associated fktable) |
Ok, I see. Then I think that it's probably not enough to just remove the |
We always skip the cuts when loading positivity datasets. I'm not entirely sure why (it has always been done like that, maybe some parts of the code needs the positivity not to be cut)
nnpdf/validphys2/src/validphys/core.py
Line 590 in f1a0eb0
However, now the positivity sets and fktables should be in the same footing as the others, so in principle we could also cut (in
x
for instance). Maybe removing this method (so that it goes to the parent, which applies the cut) is enough, but it should be tested.The text was updated successfully, but these errors were encountered: