Fix kinematic vs kinematic_coverage check #2023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
kinematic_coverage
does not contain 3 variables andlen(kinematics.variable)<=3
,extra_
variables are added to comply with vp.nnpdf/validphys2/src/validphys/commondataparser.py
Line 399 in 8b9b29f
This, however, could be inconsistent with the following check:
nnpdf/validphys2/src/validphys/commondataparser.py
Lines 435 to 439 in 8b9b29f
This is a minimal fix by basically skipping
extra_
wheneverkinematics
andkinematic_coverage
are compared.