Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default waves (no waves) crashes in multibody systems #27

Open
2 tasks
zur-quin opened this issue May 30, 2023 · 0 comments
Open
2 tasks

Default waves (no waves) crashes in multibody systems #27

zur-quin opened this issue May 30, 2023 · 0 comments

Comments

@zur-quin
Copy link
Collaborator

Currently, multibody demos for decay tests have lines like these in order to run without crashing:

    auto default_dont_add_waves = std::make_shared<NoWave>(3);

    // set up hydro forces
    std::vector<std::shared_ptr<ChBody>> bodies;
    bodies.push_back(base);
    bodies.push_back(flapFore);
    bodies.push_back(flapAft);
    TestHydro hydroforces(bodies, h5fname, default_dont_add_waves);

(From F3OF demo)
Where the default_dont_add_waves object is required to be passed. Ideally, this object should be omitted from the demo set up. If no wave object is given to hydroforces constructor, then the default should be a NoWave object with correct size for number of bodies.
In other words, the above code should be replaced with:

    // set up hydro forces
    std::vector<std::shared_ptr<ChBody>> bodies;
    bodies.push_back(base);
    bodies.push_back(flapFore);
    bodies.push_back(flapAft);
    TestHydro hydroforces(bodies, h5fname);

to have the same results. Note, this works for single body systems since the default is a NoWave(1) object.

Tasks for this issue:

  • Default NoWave should account for multibody systems as described above
  • Remove default_dont_add_waves objects from multibody decay demos to prove functionality, and increase readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant