update alt_email column on users to be null where it is an empty stri… #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng, and add uniqueness constraint on that column
gonuguntla
reviewed
Feb 3, 2021
|
|
||
| class SetUserAltEmailToNullAndAddUnique < ActiveRecord::Migration[5.0] | ||
| def change | ||
| execute "UPDATE users SET alt_email=NULL where alt_email=''" |
There was a problem hiding this comment.
how single quotes saved in alt_email column?
There was a problem hiding this comment.
In future again we will get same issue. We have to fix while saving the alt_email.
There was a problem hiding this comment.
Sure. Currently, we have a unique constraint on that column. So there can be at most only one empty alt_email row for the table. We also have code in the users.rb model file that makes sure alt_email is unique before the user object is persisted to the database.
I've updated the users model to take allowed_blank out for that field just now, so that should finish covering the '' scenario.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng, and add uniqueness constraint on that column
https://jira.nypl.org/browse/MLN-715