Create Dockerfile and docker's compose.yml file #27
Conversation
| ports: | ||
| - mode: ingress | ||
| target: 65535 | ||
| published: "65535" | ||
| protocol: tcp |
There was a problem hiding this comment.
This should be shortened:
| ports: | |
| - mode: ingress | |
| target: 65535 | |
| published: "65535" | |
| protocol: tcp | |
| ports: | |
| - 65535:65535/tcp |
| networks: | ||
| default: | ||
| name: nanolimbo_default |
There was a problem hiding this comment.
Remove this section too since it's just the default network.
| networks: | |
| default: | |
| name: nanolimbo_default |
| networks: | ||
| default: null |
There was a problem hiding this comment.
This networks: section should probably be removed since Compose creates one by default itself.
| networks: | |
| default: null |
| context: . | ||
| dockerfile: Dockerfile | ||
| image: nanolimbo | ||
| container_name: nanolimbo |
There was a problem hiding this comment.
This container_name option should be omitted so Docker Compose can pick its own name. Even if you won't be running multiple instances of this service on the same machine in different folders, there's no reason in favor of setting the container name.
See also: https://stackoverflow.com/a/64370490/19003757
| container_name: nanolimbo |
|
I'm sorry I haven't noticed the comments until now, must've missed in my inbox. I can concede in most comments except the last one, the indentation seems correct in the bind mounts |
I guess I've seen it both ways in YAML, and it doesn't really affect the parsing. (I deleted that change just now, I wasn't sure how else to remove the suggestion) |
docker-compose.yml is legacy naming, currently compose.yml is the go-to given that it is meant to be a more broad standard than just docker |
This PR provides a Dockerfile capable of compiling the source code with just doing
DOCKER_BUILDKIT=1 docker buildand running it inside of a container.Together with it is bundled a compose.yml file, which requires Docker CE to be installed (not the same as regular distro provided docker, haven't tested with it though).
This can easily be used to create an image for the end user to pull from the docker registry.
Fixes #13