Aggregator message TTL #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ignores old messages
- Preserves old behavior
- Ended up not being used in tests
emlautarom1
commented
Jul 3, 2024
Hyodar
approved these changes
Jul 4, 2024
Hyodar
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There is no submission timeout for messages being sent to the aggregator, meaning that we spend time processing messages that are too old. See #212 for more details.
New Behavior
We introduce a timeout based on the Aggregator current time (Unix timestamp), rejecting messages that are too old. We also adjust the checkpoint time range logic to be
(lastCheckpointTimestamp + 1) to (currentTime - TIMEOUT)Breaking Changes
There is a risk of now dropping messages if the timeouts are too strict. We'll need to monitor this change once its deployed.
Observations
The initial implementation uses a 60 second timeout. We also introduce a
Clockabstraction for ease of testing that could be used in other parts of the codebase. It's up to discussion if we want to introduce a third-party library with more features to cover this use case.