-
-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update request: rnnoise 2021-01-22 → 0.2 #304433
Comments
The missing file is downloaded as part of the 'autogen.sh' |
Perhaps it can be fetched using fetchurl/fetchpatch? |
You're correct. The relevant file is retrieved in the script download_model.sh. It fetches a single file from the URL model_version = "0b50c45";
model = fetchurl {
url = "https://media.xiph.org/rnnoise/models/rnnoise_data-${model_version}.tar.gz";
hash = "sha256-SsgcXAiE7EvVkHAmqq4WIJt7ds2df3GvWCCUovmPS0M=";
};
preBuild = ''
tar xvomf $model
''; |
Alternatively you could use While we are at it, we should be using the main repository instead just Microsoft GitHub which is explicitly listed as a mirror, not the primary code forge. Something like {
srcs = [
(fetchzip {
name = "…";
urls = [
"https://gitlab.xiph.org/xiph/rnnoise/-/archive/v${finalAttrs.version}/rnnoise-v${finalAttrs.version}.tar.gz"
"https://github.com/xiph/rnnoise/archive/v${finalAttrs.version}.tar.gz"
];
hash = "…";
})
(fetchurl {
# model
})
];
} Referencing both mirrors would be more resilient for when one of these platforms goes down. |
Made a PR #305348, but still having trouble designing a proper update script. |
Notify maintainers
@nh2
Note for maintainers: Please tag this issue in your PR.
https://gitlab.xiph.org/xiph/rnnoise/-/tree/v0.2
https://github.com/xiph/rnnoise/releases/tag/v0.2
Tried building with
but it got a missing file.
There’s also warning about not using SSE3/AVX/AVX2, but Nix only supports the bottom of the barrel, common x86 instructions, but I usually compile this one out with some flags.
Add a 👍 reaction to issues you find important.
1
Footnotes
Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute. ↩
The text was updated successfully, but these errors were encountered: