Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in LAW=7 and LAW=9 #19

Open
HunterBelanger opened this issue Mar 27, 2021 · 2 comments
Open

Bugs in LAW=7 and LAW=9 #19

HunterBelanger opened this issue Mar 27, 2021 · 2 comments

Comments

@HunterBelanger
Copy link

For LAW=7 (Maxwellian), the definition of the normalization constant I does not match the definition found in the ENDF manual.

For LAW=9 (Evaporation), the form of the distribution does not agree with that found in the ENDF manual (should be E_{out} in the numerator, and not \sqrt{E_{out}}). There is a note however which explicitly states that the form of the distribution for Maxwellian and Evaporation should be the same. Assuming that the ENDF version of these distributions is correct, then this note is also inaccurate.

I have fixes prepared for both of these, I just want to make sure that the LAW=9 discrepancy is indeed a bug (as the explicit note makes me somewhat suspicious).

@paulromano
Copy link
Collaborator

@HunterBelanger I agree with you on both counts. The form of the distribution for LAW=9 is definitely not the same as LAW=7, so I'm also puzzled as to why there's a note saying they should be the same.

@HunterBelanger
Copy link
Author

@paulromano Thanks for confirming my suspicions ! I will go ahead and submit my fix for this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants