Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise which methods are exported by the API #394

Open
mvanzulli opened this issue Jul 1, 2023 · 2 comments
Open

Revise which methods are exported by the API #394

mvanzulli opened this issue Jul 1, 2023 · 2 comments
Labels
interfaces refactor Refactoring releated issues

Comments

@mvanzulli
Copy link
Member

mvanzulli commented Jul 1, 2023 •
edited
Loading

I think it's fair enough to think of each constituent module of ONSAS "first class" in the sense that whatever is exported should also be re-exported in ONSAS proper.
@mvanzulli mvanzulli added interfaces refactor Refactoring releated issues labels Jul 1, 2023
@mforets
Copy link
Collaborator

mforets commented Jul 1, 2023

_solve! and _step! are two candidates.

This was referenced Jul 1, 2023
Merged
Merged
Merged
@mforets
Copy link
Collaborator

mforets commented Jul 1, 2023

I made a pass through the whole library and I think that only _update! and _solve! are missing.

@mforets mforets mentioned this issue Jul 1, 2023
Merged
mvanzulli added a commit that referenced this issue Jul 1, 2023
@mvanzulli
Merge pull request #397 from ONSAS/mforets/reset_assemble
1de25ba 
Rename reset assemble (#394)
mvanzulli added a commit that referenced this issue Jul 1, 2023
@mvanzulli
Merge pull request #398 from ONSAS/mforets/update
f1445ff 
Rename update (#394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interfaces refactor Refactoring releated issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mforets @mvanzulli