Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plural names check not working properly #17

Open
tgoprince opened this issue Mar 11, 2020 · 1 comment
Open

Plural names check not working properly #17

tgoprince opened this issue Mar 11, 2020 · 1 comment
Assignees
Labels
bug Something isn't working verification

Comments

@tgoprince
Copy link
Member

The verification feature that checks if a class has a plural name is not working properly. It is complaining about a lot of cases which it should not.

See example below:

image

The class "Resident of the Netherlands" is not a plural name, as well as "Child Living with Parents".

@tgoprince tgoprince added the bug Something isn't working label Mar 11, 2020
@claudenirmf
Copy link
Member

The package used for that feature is based on a set of rules rather than some vocabulary. However, it allows us to insert new rules and define specific terms as plural or singular. Our options for this feature are either:

  1. Drop it
  2. Keep it with the bug
  3. Or build some mechanism for the user to ignore the warning

Even if we move to a different library or start using some web service, I believe that the issue would persist. Take for instance the class Opening Hours whose instances are specifications of the opening hours of a place to the public. In this case, the name is intentionally used in the plural form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working verification
Projects
None yet
Development

No branches or pull requests

2 participants