Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade in/out channels when they're activated/deactivated #1095

Open
philippitts opened this issue Jan 5, 2023 · 1 comment
Open

Fade in/out channels when they're activated/deactivated #1095

philippitts opened this issue Jan 5, 2023 · 1 comment
Assignees

Comments

@philippitts
Copy link
Member

Is your feature request related to a problem? Please describe.

When channels are activated or deactivated, it causes loud spikes in the data.

Describe the solution you'd like

When channels are enabled and/or disabled they should be smoothly transitioned in and out. This could be done by applying a combination of weights and low-pass filters.

@retiutut
Copy link
Member

retiutut commented Jan 6, 2023

When we change channel settings while streaming data, the ADS1299 is reconfigured and this does caused a small "spike" in the data on most channels. For this reason, the Hardware Settings UI can only be accessed while streaming is off.

Channel On/Off buttons have remained accessible while data is streaming, which is nice for UX and testing, but still can have this unintended effect.

Some early thoughts on this ticket. We could:

  • make channel/on off settings only accessible when streaming is off
  • do some kind of hardware magic to "hide" the spike, but then results in not accurately depicting what happens on the device

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants