Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSDLCodeGenerator filters are available to support templates #312

Open
thirtytwobits opened this issue Jun 14, 2023 · 0 comments
Open

DSDLCodeGenerator filters are available to support templates #312

thirtytwobits opened this issue Jun 14, 2023 · 0 comments
Labels
minor Something that needs to be done but isn't urgent.

Comments

@thirtytwobits
Copy link
Member

While nothing terrible comes of this it does rely on an unstable ordering of generator initialization. That is, when the support generator is initialized the DSDLCodeGenerator templates are not available, however, when generating code they are because the DSDLCodeGenerator added them to a shared environment when it initialized.

Possible fixes include:

  1. just moving all the generator filters to the environment.
  2. creating different environment objects per generator
  3. sandboxing filters and tests based on the code generator in use (not recommended).
@thirtytwobits thirtytwobits added the minor Something that needs to be done but isn't urgent. label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Something that needs to be done but isn't urgent.
Projects
None yet
Development

No branches or pull requests

1 participant