Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Improve error handling of Ganache subprocess errors #26

Open
frangio opened this issue Nov 23, 2019 · 0 comments
Open

Improve error handling of Ganache subprocess errors #26

frangio opened this issue Nov 23, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@frangio
Copy link
Contributor

frangio commented Nov 23, 2019

We're not doing any error handling in the Ganache subprocess and I believe this could result in the process dying and then the main process failing to submit transactions. It's not clear to me what would happen in that case: timeouts or errors? It should be possible to catch errors and report them back to the main process through the IPC channel. Consider using the uncaughtException event.

@abcoathup abcoathup added the enhancement New feature or request label Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants