Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

Add support for ethers.js-style contract abstraction #29

Open
pcowgill opened this issue Dec 6, 2019 · 4 comments
Open

Add support for ethers.js-style contract abstraction #29

pcowgill opened this issue Dec 6, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@pcowgill
Copy link

pcowgill commented Dec 6, 2019

No description provided.

@pcowgill
Copy link
Author

pcowgill commented Dec 6, 2019

Twitter conversation about how this could be implemented

@ylv-io
Copy link
Contributor

ylv-io commented Dec 9, 2019

Hey @pcowgill. Things are looking promising for ethers.js. I'll keep posting updates to this issue.

@frangio
Copy link
Contributor

frangio commented Dec 9, 2019

What would be the scope of this?

We clearly would allow choosing ethers.js contract abstractions, by specifying contracts: 'ether' in the config.

Additionally, I suppose we would export a preconfigured ethers.js provider? One issue with that is that we currently export a provider that is a web3.js provider so we have to either give the ethers.js provider export a new name, or allow the user to choose the provider type (though this is super weird because they're not the same thing conceptually).

@pcowgill
Copy link
Author

@frangio I think it's a good idea to give the ethers export a different name, especially since ethers has separate notions of signer and provider - I wish web3.js did too. When you add it, maybe make a breaking change to call the existing provider web3Provider?

@abcoathup abcoathup added the enhancement New feature or request label Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants