Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forked dependencies #406

Open
thewilkybarkid opened this issue Sep 7, 2021 · 0 comments
Open

Remove forked dependencies #406

thewilkybarkid opened this issue Sep 7, 2021 · 0 comments

Comments

@thewilkybarkid
Copy link
Member

The dependency list contains some forks, this isn't sustainable and whatever change they were making needs to be resolved.

thewilkybarkid added a commit that referenced this issue Sep 7, 2021
Remove use of a forked dependency. The fork appears to add in an 'optional' option, which is undocumented and seemingly untested. It seems to work without it too.

The dependency has seen some updates, too, including TypeScript changes required for using strict mode (CyriacBr/class-fixtures-factory#10).

Refs #406, #398
thewilkybarkid added a commit that referenced this issue Oct 21, 2021
NPM supports dependencies on GitHub natively, so we don't have to reference a Git repository directly.

Refs #406
thewilkybarkid added a commit that referenced this issue Oct 21, 2021
The generated data fixtures in the dev environment aren't helpful as they're not realistic. But worse, there are quite a few problems in this area:

- It fails to run roughly half the time.
- The forked dependency is blocking npm updates.
- The ORM overall is blocking Parcel updates.

Rather than trying to resolve all the issues, this change removes the fixture generation entirely. As a result, the codebase is a fraction simpler.

Refs #399, #406, #421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant