Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to make multiple rapid PREreviews #408

Open
murkatr opened this issue Sep 21, 2021 · 2 comments
Open

Remove ability to make multiple rapid PREreviews #408

murkatr opened this issue Sep 21, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@murkatr
Copy link
Contributor

murkatr commented Sep 21, 2021

Here I posted two separate rapid PREreviews - one under my anonymous profile and one under my public profile and they both showed up as anonymous with two separate entries.

We want to make sure users can only submit one rapid PREreview and one full PREreview per preprint.

@murkatr murkatr added the bug Something isn't working label Sep 21, 2021
@thewilkybarkid
Copy link
Member

I can recreate this locally. There's two things to look at:

  1. The API needs to reject the second request.
  2. The frontend needs to not display the form the second time.

The former's probably easier to start with, and will break the frontend's form (so at least there won't be duplicates).

@murkatr
Copy link
Contributor Author

murkatr commented Sep 22, 2021

Sounds like a great plan! I am interested in keeping my public rapid PREreview entry if possible, no worries if not.

thewilkybarkid added a commit that referenced this issue Oct 4, 2021
… API

Adds test cases for submitting rapid reviews as an authenticated API user and an anonymous user.

Only one of the cases fails, as it's possible to submit more than once.

Refs #388, #408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants