Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments for full reviews aren't displayed #424

Open
thewilkybarkid opened this issue Nov 9, 2021 · 1 comment
Open

Comments for full reviews aren't displayed #424

thewilkybarkid opened this issue Nov 9, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@thewilkybarkid
Copy link
Member

The review by Purple Hamster on https://prereview.org/preprints/ac0dc5be-4e85-424c-8659-d9c588b7dbc5 has 2 comments which can be seen through the API:

curl --silent https://prereview.org/api/v2/full-reviews/e5334cdf-9c8e-4600-9e78-0f17156937c0 | jq .body[0].comments
[
  {
    "uuid": "e197f9af-a451-4602-b983-88a195bfba99",
    "createdAt": "2021-11-01T08:28:56.000Z",
    "updatedAt": "2021-11-01T08:28:56.000Z",
    "contents": "<div class=\"ql-editor\" data-gramm=\"false\" data-placeholder=\"Comment section (maximum 150 words)\" contenteditable=\"true\"><p>Hi, thank you for your the review! It was very helpful. The response to review with our comments is now uploaded to the paper repository (https://doi.org/10.31219/osf.io/enzgs) and can also be viewed on Github (</p><p>https://htmlpreview.github.io/?https://github.com/dmi3kno/ilbm-article/blob/master/PREreviews/reponse1.html).</p><p><br></p><p>Supplementary materials contain everything required for reproducing the article, including README file, which, when knitted in R, will produce all models and cache them in special directory (courtesy of `targets` package). The same can be done by cloning the project from Github https://github.com/dmi3kno/ilbm-article/</p></div><div class=\"ql-clipboard\" tabindex=\"-1\" contenteditable=\"true\"></div><div class=\"ql-tooltip ql-hidden\"><a class=\"ql-preview\" rel=\"noopener noreferrer\" target=\"_blank\" href=\"about:blank\"></a><input type=\"text\" data-formula=\"e=mc^2\" data-link=\"https://quilljs.com\" data-video=\"Embed URL\"><a class=\"ql-action\"></a><a class=\"ql-remove\"></a></div>",
    "isPublished": true,
    "isFlagged": false,
    "author": 2218,
    "parent": 184
  },
  {
    "uuid": "f9b2467b-801b-4157-adf1-258385871d5c",
    "createdAt": "2021-11-05T20:26:20.000Z",
    "updatedAt": "2021-11-05T20:26:20.000Z",
    "contents": "<div class=\"ql-editor\" data-gramm=\"false\" data-placeholder=\"Comment section (maximum 150 words)\" contenteditable=\"true\"><p>Dear Reviewer! Thank you for your comments. The new version addressing the issues you raised is uploaded to the repository. Please find the detailed response in the PREreview folder. </p></div><div class=\"ql-clipboard\" tabindex=\"-1\" contenteditable=\"true\"></div><div class=\"ql-tooltip ql-hidden\"><a class=\"ql-preview\" rel=\"noopener noreferrer\" target=\"_blank\" href=\"about:blank\"></a><input type=\"text\" data-formula=\"e=mc^2\" data-link=\"https://quilljs.com\" data-video=\"Embed URL\"><a class=\"ql-action\"></a><a class=\"ql-remove\"></a></div>",
    "isPublished": true,
    "isFlagged": false,
    "author": 2218,
    "parent": 184
  }
]

But the page shows:

image

@thewilkybarkid thewilkybarkid added the bug Something isn't working label Nov 9, 2021
@thewilkybarkid
Copy link
Member Author

Looking at the requests the frontend makes, it finds out about the full review through a request to the preprint (https://prereview.org/api/v2/preprints/ac0dc5be-4e85-424c-8659-d9c588b7dbc5). But that is only a subset of the information available for the full reviews, and doesn't contain the comments. So, I don't think comments will be showing on any review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant