Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community members added still seeing "join community" button #431

Open
dasaderi opened this issue Dec 13, 2021 · 2 comments
Open

Community members added still seeing "join community" button #431

dasaderi opened this issue Dec 13, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@dasaderi
Copy link
Member

@thewilkybarkid adding this issue from the same PREreviewer who contacted us about now solved issue #429. They said that community members added with their public personas are still seeing the "join the community button" even when they have active the same persona that was added. Probably similar issue to #429?

@thewilkybarkid thewilkybarkid added the bug Something isn't working label Dec 14, 2021
@thewilkybarkid
Copy link
Member

Looking at

{isOwner ? (
<IconButton
href={`/community-settings/${community.uuid}`}
className={classes.settings}
>
<SettingsIcon
className={classes.settingsIcon}
style={{ fontSize: 40 }}
/>
<Hidden xsUp>
<span>Settings</span>
</Hidden>
</IconButton>
) : (
<Box className={classes.request}>
<Button
color="primary"
variant="contained"
className={classes.button}
onClick={handleJoinRequest}
>
Request to join community
</Button>
</Box>
)}
you see the settings button if you're an owner, or the 'join' button otherwise (even if you are a member already).

thewilkybarkid added a commit that referenced this issue Dec 14, 2021
This change adds test cases for seeing or not the edit community button.

I've had to add a label to the button to select it, which also helps make it a little more accessible.

Refs #388, #431
thewilkybarkid added a commit that referenced this issue Dec 14, 2021
This change adds test cases for joining a community. It includes a failing case for existing members who still see the button to join.

Refs #388, #431
@dasaderi
Copy link
Member Author

Interesting. Well that looks like a bug. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants