Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ed25519 Support #57

Open
apowers313 opened this issue Apr 14, 2018 · 10 comments
Open

Ed25519 Support #57

apowers313 opened this issue Apr 14, 2018 · 10 comments

Comments

@apowers313
Copy link

Based on the conversation in PeculiarVentures/PKI.js#164 I'm hoping I can get help with adding the Ed25519 curve to webcrypto-liner. It looks like @microshine just added secp256k1 -- I'm assuming the easiest path is to look at those edits and copy them?

I'm a little concerned about whether or not I'm going to be successful in creating a PR here without a significant investment of time. Any help would be appreciated.

@microshine
Copy link
Contributor

@apowers313 webcrypto-liner is based on webcrypto-core which supports X25519 named curve.
You can use this curve like standard WebCrypto curves (e.g. P-256, P-384, P-521)

node-webcrypto-p11 implements X25519. It hes test for key derivation for NSS PKCS#11

@Mischala
Copy link

Mischala commented Oct 8, 2018

I have done some work upstream in webcrypto-core to add EdDSA, and plan to implement it here in an upcoming PR.
After the webcrypto-core PR is merged and published

@Mischala
Copy link

Mischala commented Nov 5, 2018

changes made in #61

@TJKoury
Copy link
Contributor

TJKoury commented Jun 5, 2019

@Mischala @microshine What's the status here? Is this going to be integrated soon? I'm willing to work on it if needed.

@rmhrisk
Copy link
Contributor

rmhrisk commented Jun 5, 2019

No progress but we’re interested in a PR :)

@TJKoury
Copy link
Contributor

TJKoury commented Jun 5, 2019

@Mischala checking out your fork, what was the stopping point there? Some technical issue?

@microshine
Copy link
Contributor

@peculiar/webcrypto implements EdDSA and ECDH-ES mechanism. I'm going to support the same mechanisms for webcrypto-liner (~1 week)

@microshine
Copy link
Contributor

Try this example. But copy files locally and run it. It doesn't work in codesandbox (not clear why)
https://codesandbox.io/s/ed25519-with-certs-goxlt

image

It uses an unpublished webcrypto-liner library with Ed25519 supporting

@microshine
Copy link
Contributor

There is a problem with Ed448 curve. elliptic module doesn't implement it. So current version supports Ed25519 only

@rmhrisk
Copy link
Contributor

rmhrisk commented Feb 9, 2021

@indutny any chance to get Ed448 working in elliptic for our use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants