Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have webdav directory listing utilize token-based authorization #25

Closed
bbockelm opened this issue Jul 28, 2023 · 6 comments · Fixed by #165
Closed

Have webdav directory listing utilize token-based authorization #25

bbockelm opened this issue Jul 28, 2023 · 6 comments · Fixed by #165
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bbockelm
Copy link
Collaborator

We think, when stashcp does the directory existence test, it uses a library that doesn't leverage the bearer token. Investigate this issue and, as necessary, add token support.

Alternately, if token support isn't available, rip out this code.

@bbockelm
Copy link
Collaborator Author

@matyasselmeci points out this probably also breaks recursive transfers (which increases the priority to fix).

@bbockelm bbockelm added this to the v7.1.0 milestone Aug 31, 2023
@bbockelm bbockelm self-assigned this Aug 31, 2023
@bbockelm bbockelm added the enhancement New feature or request label Sep 1, 2023
@bbockelm bbockelm assigned turetske and unassigned bbockelm Sep 7, 2023
@turetske
Copy link
Contributor

turetske commented Sep 8, 2023

Client side code. Interface for listing remote directories. The token isn't being passed to the web-dev library or it's being passed. "list-directory" function. Possibly customize the http headers.

@turetske
Copy link
Contributor

turetske commented Sep 29, 2023

@bbockelm Looking into the code, gowebdav doesn't support this. However, there is an open issue for a fix on their repo, how do we feel about me attempting that rather than ripping out the code?

@bbockelm
Copy link
Collaborator Author

What's the GH issue you found? We should at least get that linked to this one.

@turetske
Copy link
Contributor

What's the GH issue you found? We should at least get that linked to this one.

It's linked here: studio-b12/gowebdav#61

I did look into adding the support to the base web directory, but honestly my token/http knowledge still feels to weak to do so, so instead I'm removing the isDir code and we can fix it later.

@bbockelm bbockelm linked a pull request Oct 1, 2023 that will close this issue
@bbockelm
Copy link
Collaborator Author

bbockelm commented Oct 1, 2023

I'm OK with fixing the directory listing / upload on a future ticket. Will merge the PR momentarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants