tweak: improve types for test frameworks (#84)

PhpGt · Apr 29, 2023 · a7e0856 · a7e0856
1 parent 8c80353
commit a7e0856
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/Curl.php b/src/Curl.php
@@ -201,8 +201,13 @@ public function unescape(string $str):string {
 
 	/**
 	 * Obtain the underlying curl resource, as created with curl_init.
+	 * The return type is purposefully missing, to allow for test frameworks
+	 * to extend this class to provide stubbed HTTP functionality.
+	 *
+	 * @return CurlHandle
+	 * @noinspection PhpMissingReturnTypeInspection
 	 */
-	public function getHandle():CurlHandle {
+	public function getHandle() {
 		return $this->ch;
 	}
 
@@ -218,10 +223,10 @@ public function getAllInfo():array {
 	}
 
 	public function getHeaderFunction():?callable {
-		return $this->headerFunction ?? null;
+		return $this->headerFunction;
 	}
 
 	public function getWriteFunction():?callable {
-		return $this->writeFunction ?? null;
+		return $this->writeFunction;
 	}
 }
diff --git a/src/CurlInterface.php b/src/CurlInterface.php
@@ -105,8 +105,13 @@ public function unescape(string $str):string;
 
 	/**
 	 * Obtain the underlying curl resource, as created with curl_init.
+	 * The return type is purposefully missing, to allow for test frameworks
+	 * to extend this class to provide stubbed HTTP functionality.
+	 *
+	 * @return CurlHandle
+	 * @noinspection PhpMissingReturnTypeInspection
 	 */
-	public function getHandle():CurlHandle;
+	public function getHandle();
 
 	/**
 	 * Gets all CURLINFO_ data, identical to calling