Add subscribe/unsubscribe button on UI #156
Conversation
| initTest(SCREEN_WIDTH); | ||
| jest | ||
| .spyOn(Router, "useParams") | ||
| .mockReturnValue({ bookId: UNSUBSCRIBED_BOOK }); |
There was a problem hiding this comment.
Name shouldn't be unsubscribed book, as we don't have that status in our system
| initTest(SCREEN_WIDTH); | ||
| jest | ||
| .spyOn(Router, "useParams") | ||
| .mockReturnValue({ bookId: SUBSCRIBED_BOOK }); |
There was a problem hiding this comment.
Also here, in this moment I suppose we are not subscribed?
src/services/BookService.tsx
Outdated
| export const getSubscription = async (bookId: number) => | ||
| client.get(`/inventory/subscriptions/${bookId}`); |
There was a problem hiding this comment.
We have mechanism in gateway of fetching all data for book details page. Getting subscription information should be done there, and then we wouldn't have getSubscription on our client
src/services/BookService.tsx
Outdated
| export const getSubscription = async (bookId: number) => | ||
| client.get(`/inventory/subscriptions/${bookId}`); | ||
|
|
||
| export const postSubscribe = async (bookId: number) => |
src/services/BookService.tsx
Outdated
| export const postSubscribe = async (bookId: number) => | ||
| client.post(`/inventory/subscriptions/subscribe/${bookId}`); | ||
|
|
||
| export const postUnsubscribe = async (bookId: number) => |
There was a problem hiding this comment.
We should discuss is this candidate for http POST method or DELETE
src/hooks/useSubscribe.tsx
Outdated
| import { useEffect, useState } from "react"; | ||
| import * as bookService from "../services/BookService"; | ||
|
|
||
| const useSubscribe = (bookId: number) => { |
There was a problem hiding this comment.
useBookSubscription
| const { showSuccessScreen } = useSuccessScreenContext(); | ||
|
|
||
| const subscribeClick = () => { | ||
| subscribe().then(() => { |
There was a problem hiding this comment.
What happens when subscribe or unsubscribe api fails? We should think of showing error message for the user.
Added subscription buttons on book details page with tests.