Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review WorkflowManager WorkflowRequestEvent logic #670

Open
JoeBatt1989 opened this issue Feb 6, 2023 · 1 comment
Open

Review WorkflowManager WorkflowRequestEvent logic #670

JoeBatt1989 opened this issue Feb 6, 2023 · 1 comment

Comments

@JoeBatt1989
Copy link
Contributor

The WorkflowRequestEvent logic seems dependent on the size of the study sent. This ticket is to review the logic around consuming WorkflowRequestEvent and seeing if there are any potential performance improvements. Details of what was seen during the performance test can be seen below. CT (324 slices) is by far the longest processing time, which conditional logic oly making 1-2 seconds difference, which is expected.

Modality DICOM Payload Processed Task Dispatched (WorkflowRequestEvent cosumption)
Average (sec) Max (sec) Average (sec)
CT1 ("{{ context.dicom.series.all('0008','0060') }} == 'CT'") 34.4 36.2
CT1 ("{{ context.dicom.series.any('0008','0060') }} == 'CT'") 34.2 37.8
MR 1.1 1.4
US 1.7 2.3
RF 0.7 1.2
CT (executing Small app or conditional logic) 34.9 37.9
RF (no conditional logic) 0.7 0.9
@mocsharp
Copy link
Collaborator

mocsharp commented Feb 6, 2023

If performance is related to the number of (DICOM JSON) files, then we may consider improving it with Project-MONAI/monai-deploy-informatics-gateway#83.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants