Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write unit tests #35

Open
ankitr opened this issue Jul 28, 2016 · 5 comments
Open

Write unit tests #35

ankitr opened this issue Jul 28, 2016 · 5 comments

Comments

@ankitr
Copy link
Member

ankitr commented Jul 28, 2016

Let's make sure things work. I'll look into setting up continuous integration once we have that.

@ankitr
Copy link
Member Author

ankitr commented Aug 2, 2016

I'll see what I can do about a Mocha integration.

@ankitr ankitr assigned gmittal and unassigned ankitr Aug 2, 2016
@ankitr
Copy link
Member Author

ankitr commented Aug 2, 2016

Now it's on @gmittal to actually test things 😉

@gmittal
Copy link
Member

gmittal commented Jan 16, 2017

One thing to consider is how to test functions such as sending an SMS/email (because that has a tendency to break silently).

Sending an SMS from the Twilio number to itself should work. It'll test both the sending functionality (which Twilio will complain about if something is configured poorly) and the receiving handler (which mailroom will complain about as well).

Proof you can SMS yourself (we already knew you could email yourself):
you can SMS yourself

@gmittal
Copy link
Member

gmittal commented May 21, 2017

After the Twilio incident (#75) finally taking a look at this again.

@gmittal
Copy link
Member

gmittal commented May 21, 2017

WIP with #76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants