Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected members (and @property)? #27

Open
mrava87 opened this issue Jan 9, 2019 · 2 comments
Open

Protected members (and @property)? #27

mrava87 opened this issue Jan 9, 2019 · 2 comments
Labels
Core Pulls for core PyLops library enhancement New feature or request

Comments

@mrava87
Copy link
Collaborator

mrava87 commented Jan 9, 2019

So far the convention of prepending _ to highlight protected members is not used. While no operator requires the user to change anything after initialization and its use is limited to * (or matvec) and .H (or rmatvec), it may be better to be consistent with common practice.

Also, in some cases some variables are checked at initialization, it may more natural to convert those into @property. This is not just a pure stylistic change but may make better code (although will raise the bar for new developers?)

@mrava87 mrava87 added Core Pulls for core PyLops library enhancement New feature or request labels Dec 29, 2021
@mrava87 mrava87 added this to To do in v2.0.0 Dec 29, 2021
@mrava87 mrava87 removed this from To do in v2.0.0 Oct 11, 2022
@dikwickley
Copy link
Contributor

Hi @mrava87 is this issue still open? I would like to work on this

@mrava87
Copy link
Collaborator Author

mrava87 commented Feb 13, 2023

Hi, we have done this for the key class, LinearOperator. I am not so convinced it makes sense to do it for every single operator… I suggest not to work on this (I keep it open until we are sure we don’t want to make this happen in the long run either…)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Pulls for core PyLops library enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants