Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Exceptions are not handled and break the plugin #1

Open
SuperRayss opened this issue Jan 28, 2020 · 1 comment
Open

[BUG] Exceptions are not handled and break the plugin #1

SuperRayss opened this issue Jan 28, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@SuperRayss
Copy link
Collaborator

The following exception was encountered when attempting to give a player an item while the player was still in the lobby. As a result, the plugin would not take commands anymore. NullReferenceExceptions need to be handled by the plugin before invoking the command, or there needs to be another solution to clear the console to be used again by the plugin (other methods of input like R2DSE still work). The exception was as follows:

[Error : Unity Log] NullReferenceException: Object reference not set to an instance of an object
Stack trace:
DebugToolkit.DebugToolkit.CCGiveItem (RoR2.ConCommandArgs args) (at :0)
DMD?-714778880._RunCmd (RoR2.Console this, RoR2.NetworkUser sender, System.String concommandName, System.Collections.Generic.List1[T] userArgs) (at <117d33b4b4d64b7381d325f27597b5fe>:0) R2DSEssentials.Modules.ChatCommands.Console_RunCmd (On.RoR2.Console+orig_RunCmd orig, RoR2.Console self, RoR2.NetworkUser sender, System.String concommandName, System.Collections.Generic.List1[T] userArgs) (at :0)
DMD<>?-714778880._Hook<RoR2_Console::RunCmd>?833395072 (RoR2.Console , RoR2.NetworkUser , System.String , System.Collections.Generic.List1[T] ) (at <41b6dc7688114ef6b73de9a209d79038>:0) DebugToolkit.Hooks.LogNetworkCommandsAndCheckPermissions (On.RoR2.Console+orig_RunCmd orig, RoR2.Console self, RoR2.NetworkUser sender, System.String concommandName, System.Collections.Generic.List1[T] userArgs) (at :0)
DMD<>?-714778880._Hook<RoR2_Console::RunCmd>?-894164096 (RoR2.Console , RoR2.NetworkUser , System.String , System.Collections.Generic.List1[T] ) (at <4d8bbff19ff9400c80a4e6dd34b92216>:0) DropInMultiplayer.DropInMultiplayer.CheckIfCmdIsRequest (On.RoR2.Console+orig_RunCmd orig, RoR2.Console self, RoR2.NetworkUser sender, System.String conCommandName, System.Collections.Generic.List1[T] userArgs) (at <7de7db238a22476d817040052647ebe1>:0)
DMD<>?-714778880._Hook<RoR2_Console::RunCmd>?1191277952 (RoR2.Console , RoR2.NetworkUser , System.String , System.Collections.Generic.List`1[T] ) (at :0)
RoR2.Console.SubmitCmd (RoR2.NetworkUser sender, System.String cmd, System.Boolean recordSubmit) (at <9adb18c5484340e58a7afc9827db1de0>:0)
BotCMDs.BotCommands+d__7.MoveNext () (at <1baec3259a294b818091c388dcf27e43>:0)
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () (at :0)
System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.b__6_0 (System.Object state) (at :0)
UnityEngine.UnitySynchronizationContext+WorkRequest.Invoke () (at :0)
UnityEngine.UnitySynchronizationContext:ExecuteTasks()

@InfernalPlacebo
Copy link
Contributor

I believe this has been fixed, are you able to verify?

@InfernalPlacebo InfernalPlacebo added the bug Something isn't working label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants