Merge pull request #29 from Qase/FIX/write_external_storage_permission

Fix/write external storage permission
Qase · May 24, 2022 · 43688a3 · 43688a3
2 parents e7e1117 + 4a8b621
commit 43688a3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/kotlinlog/build.gradle b/kotlinlog/build.gradle
@@ -9,8 +9,8 @@ android {
     defaultConfig {
         minSdkVersion 16
         targetSdkVersion 28
-        versionCode 4
-        versionName "2.2.9"
+        versionCode 5
+        versionName "2.2.10"
         buildConfigField 'int', 'VERSION_CODE', "$versionCode"
         buildConfigField 'String', 'VERSION_NAME', "\"$versionName\""
         consumerProguardFile('proguard-rules.pro')

diff --git a/kotlinlog/src/main/kotlin/quanti/com/kotlinlog/utils/PermissionHelper.kt b/kotlinlog/src/main/kotlin/quanti/com/kotlinlog/utils/PermissionHelper.kt
@@ -2,6 +2,7 @@ package quanti.com.kotlinlog.utils
 
 import android.content.Context
 import android.content.pm.PackageManager
+import android.os.Build
 import androidx.core.content.ContextCompat
 
 /**
@@ -20,7 +21,11 @@ fun Context.checkPermission(permission: String) = ContextCompat.checkSelfPermiss
  */
 fun Context.hasPermission(permission: String) = checkPermission(permission) == PackageManager.PERMISSION_GRANTED
 
-fun Context.hasFileWritePermission() = hasPermission(android.Manifest.permission.WRITE_EXTERNAL_STORAGE)
+/**
+ * Returns true if Write external storage permission is provided
+ * or if the Android is >= Android 10 since this permission is irrelevant for those versions
+ */
+fun Context.hasFileWritePermission() = hasPermission(android.Manifest.permission.WRITE_EXTERNAL_STORAGE) || (Build.VERSION.SDK_INT >= 29)