Skip to content

Commit

Permalink
Merge pull request #217 from Qovery/fix/cpu_mem_container_app_min_req…
Browse files Browse the repository at this point in the history
…uest

fix: set min values according to Qovery standards
  • Loading branch information
deimosfr committed Apr 25, 2023
2 parents 92b8cf5 + 2f0f523 commit e00d384
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/resources/application.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ You can find complete examples within these repositories:
- Required if: `build_mode="BUILDPACKS"`.
- Can be: `CLOJURE`, `GO`, `GRADLE`, `GRAILS`, `JAVA`, `JVM`, `NODE_JS`, `PHP`, `PLAY`, `PYTHON`, `SCALA`.
- `cpu` (Number) CPU of the application in millicores (m) [1000m = 1 CPU].
- Must be: `>= 250`.
- Must be: `>= 10`.
- Default: `500`.
- `custom_domains` (Attributes Set) List of custom domains linked to this application. (see [below for nested schema](#nestedatt--custom_domains))
- `deployment_stage_id` (String) Id of the deployment stage.
Expand Down
4 changes: 2 additions & 2 deletions docs/resources/container.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ resource "qovery_container" "my_container" {
- `arguments` (List of String) List of arguments of this container.
- `auto_preview` (Boolean) Specify if the environment preview option is activated or not for this container.
- `cpu` (Number) CPU of the container in millicores (m) [1000m = 1 CPU].
- Must be: `>= 250`.
- Must be: `>= 10`.
- Default: `500`.
- `deployment_stage_id` (String) Id of the deployment stage.
- `entrypoint` (String) Entrypoint of the container.
Expand All @@ -65,7 +65,7 @@ resource "qovery_container" "my_container" {
- Must be: `>= -1`.
- Default: `1`.
- `memory` (Number) RAM of the container in MB [1024MB = 1GB].
- Must be: `>= 1`.
- Must be: `>= 10`.
- Default: `512`.
- `min_running_instances` (Number) Minimum number of instances running for the container.
- Must be: `>= 1`.
Expand Down
4 changes: 2 additions & 2 deletions internal/domain/container/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ import (
const (
DefaultState = status.StateDeployed
DefaultCPU = 500
MinCPU = 250
MinCPU = 10
DefaultMemory = 512
MinMemory = 1
MinMemory = 10
DefaultMinRunningInstances = 1
MinMinRunningInstances = 1
DefaultMaxRunningInstances = 1
Expand Down
2 changes: 1 addition & 1 deletion qovery/resource_application.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ var (
applicationBuildPackLanguages = clientEnumToStringArray(qovery.AllowedBuildPackLanguageEnumEnumValues)

// Application CPU
applicationCPUMin int64 = 250 // in MB
applicationCPUMin int64 = 10 // in MB
applicationCPUDefault int64 = 500 // in MB

// Application Memory
Expand Down

0 comments on commit e00d384

Please sign in to comment.