Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: First offer selecting an app version then download #1988

Open
3 tasks done
oSumAtrIX opened this issue Jun 22, 2024 · 2 comments
Open
3 tasks done

feat: First offer selecting an app version then download #1988

oSumAtrIX opened this issue Jun 22, 2024 · 2 comments
Labels
Depends on Downloader Issues that will no longer be applicable after the downloader is removed Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager

Comments

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jun 22, 2024

Feature description

Right now selecting an app brings you to the download screen if not installed. That screen needs to first load in order to display versions. Instead the user should first be prompted to chose a version , or all versions should show up and a loading icon can be displayed next to it. Once it found a download for that version, it could say it with a label in place of the loading icon "Can download". Versions that can not be downloaded should be prompted to be selected from storage when clicked on. The app should then check the version once it is selected and warn the user if the version doesn't match.

The suggested version should also be highlighted. Right now it only shows this for example:

image

A list with one item is for example quite weird to a user seeing this screen for the first time.

Acknowledgements

  • This issue is not a duplicate of an existing feature request.
  • I have chosen an appropriate title.
  • The feature request is only related to ReVanced Manager
@oSumAtrIX oSumAtrIX added Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager labels Jun 22, 2024
@Ushie
Copy link
Member

Ushie commented Jun 22, 2024

The app doesn't download at this stage, the app download begins once you enter the patcher screen, upto that point it is nothing more than just a setting

@oSumAtrIX
Copy link
Member Author

oSumAtrIX commented Jun 22, 2024

The app doesn't download at this stage, the app download begins once you enter the patcher screen, upto that point it is nothing more than just a setting

It crawls at this stage which is an unnecessary delay. This should be done asynchronously, when a version is selected the other parallel tasks in search for a download can be stopped and once the download for that version is found it can proceed.

@Axelen123 Axelen123 added the Depends on Downloader Issues that will no longer be applicable after the downloader is removed label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Depends on Downloader Issues that will no longer be applicable after the downloader is removed Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

No branches or pull requests

3 participants