Add optional callbacks to the collectLatest and combineLatestUpdates #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterwln
reviewed
Apr 10, 2024
| @@ -94,7 +100,11 @@ function next_received!(wrapper::CollectLatestObservableWrapper, data, index::Ca | |||
| @inbounds wrapper.ustatus[index] = true | |||
| if all(wrapper.vstatus) && !all(wrapper.cstatus) | |||
| unsafe_copyto!(wrapper.vstatus, 1, wrapper.cstatus, 1, length(wrapper.vstatus)) | |||
| next!(wrapper.actor, wrapper.mappingFn(wrapper.storage)) | |||
| value = wrapper.mappingFn(wrapper.storage) | |||
There was a problem hiding this comment.
Might be better to parameterize CollectLatestObservableWrapper here? I think it will compile away the call to isnothing if {C} is nothing already
There was a problem hiding this comment.
It is parametrized with C already
wouterwln
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new optional
callbackFnargument forcollectLatestandcombineLatestUpdates, which allows to call a custom function upon each execution of the collected/combined event. This is a hot-fix for a bug found inReactiveMP.