Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate some calls to ExecuteV1 to V2 transactions #48

Open
charnik opened this issue Nov 17, 2022 · 4 comments
Open

Migrate some calls to ExecuteV1 to V2 transactions #48

charnik opened this issue Nov 17, 2022 · 4 comments

Comments

@charnik
Copy link

charnik commented Nov 17, 2022

While compiling the engine's SLO log for last week with @NHDaly and @msagarpatel , we noticed a couple of places in RAI's GO SDK where a V1 type of transaction is used where a V2 type of transaction could have been directly used without any extra effort. This concerns places where the SDK compiles a Rel query as a string and submits it via ExecuteV1(). Two such places are the following:

return c.ExecuteV1(database, engine, source, inputs, false)

return c.ExecuteV1(database, engine, b.String(), inputs, false)

@NRHelmi
Copy link
Contributor

NRHelmi commented Nov 21, 2022

All SDKs are now using v2 protocol. We encourage everyone to update their code to use v2 APIs. We are keeping v1 there for backward compatibility and it will deprecated soon

@NRHelmi
Copy link
Contributor

NRHelmi commented Nov 22, 2022

Sorry I misunderstood the question:
V2 protocol is integrated in all SDKs, we still have some functionalities using the V1 protocol like load csv/json and related models actions. We are working on migrating those functionalities to V2 protocol as well.

@charnik
Copy link
Author

charnik commented Nov 22, 2022

Thank you @NRHelmi for confirming!

@billscheidel-rai
Copy link

Note: This issue has been migrated to https://relationalai.atlassian.net/browse/RAI-8002.

This link is only accessible to employees of RelationalAI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants