Customisable Font Text by user click #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digvijayu
requested changes
Apr 19, 2022
public/index.html
Outdated
| body { | ||
| overflow: hidden; | ||
| width: 350px; | ||
| margin: 0px; |
There was a problem hiding this comment.
Suggested change
| margin: 0px; | |
| margin: 0; |
public/index.html
Outdated
Comment on lines
28
to
34
| <style> | ||
| body { | ||
| overflow: hidden; | ||
| width: 350px; | ||
| margin: 0px; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
You can achieve the same thing with react
src/chrome-utils/changeText.ts
Outdated
| @@ -0,0 +1,33 @@ | |||
| export default async function changeText() { | |||
| console.log("inside async fn"); | |||
There was a problem hiding this comment.
Suggested change
| console.log("inside async fn"); |
src/chrome-utils/changeText.ts
Outdated
| export default async function changeText() { | ||
| console.log("inside async fn"); | ||
| const [tab] = await chrome.tabs.query({ active: true, currentWindow: true }); | ||
| console.log("tab.id", tab.id); |
There was a problem hiding this comment.
Suggested change
| console.log("tab.id", tab.id); |
src/chrome-utils/changeText.ts
Outdated
Comment on lines
5
to
8
| chrome.scripting.executeScript({ | ||
| target: { tabId: tab.id ? tab.id : 1111 }, | ||
| func: getTextFont, | ||
| }); |
There was a problem hiding this comment.
Suggested change
| chrome.scripting.executeScript({ | |
| target: { tabId: tab.id ? tab.id : 1111 }, | |
| func: getTextFont, | |
| }); | |
| if(tab.id) { | |
| chrome.scripting.executeScript({ | |
| target: { tabId: tab.id }, | |
| func: getTextFont, | |
| }); | |
| } |
src/chrome-utils/changeText.ts
Outdated
Comment on lines
24
to
26
| p{ | ||
| font-weight: 400 !important; | ||
| } |
There was a problem hiding this comment.
Suggested change
| p{ | |
| font-weight: 400 !important; | |
| } |
src/pages/TextSettings/index.tsx
Outdated
Comment on lines
4
to
7
| const StyledTextSettingsContainer = styled.div` | ||
| max-width: 150px; | ||
| height: 150px; | ||
| `; |
There was a problem hiding this comment.
what is the reason behind this height? Assign width and height to app instead..
src/chrome-utils/changeText.ts
Outdated
Comment on lines
5
to
8
| chrome.scripting.executeScript({ | ||
| target: { tabId: tab.id ? tab.id : 1111 }, | ||
| func: getTextFont, | ||
| }); |
There was a problem hiding this comment.
Please use the CSS injector api
digvijayu
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4
Task:
To Add custom fonts and chnage it when user clicks.
Change:
After Refactoring the extension looks something like this
Here is the before and after image after the user clicks button.
Below is the example web page, when textSetting button is not clicked and font not applied.
Below is the example web page, after button is clicked and the font is applied, this is how the text of website looks.