Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select queries should selectively columns instead of all data all the time #4

Open
RiflerRick opened this issue May 23, 2019 · 1 comment
Labels
enhancement enhancement of an existing feature good first issue Good for newcomers

Comments

@RiflerRick
Copy link
Owner

b2/src/utils.go

Line 363 in 8908cfa

baseQuery := fmt.Sprintf("SELECT * FROM %s WHERE ", *tableName)

Currently all data is selected Select * from..., however a better implementation would involve using selectively selecting columns instead of all the data, all the time.

@RiflerRick RiflerRick added the enhancement enhancement of an existing feature label May 23, 2019
@RiflerRick
Copy link
Owner Author

The column to be chosen can be chosen selectively in the same way it is chosen in case of the update query!

@RiflerRick RiflerRick added the good first issue Good for newcomers label May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of an existing feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant