-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
region selection with compton gets extra shadow #15
Comments
I've make pull request #16 that fixes it |
fixed here e57f384 |
@Brottweiler can you paste your compton's config? also which video driver are you using? |
Driver: Config:
|
Well, after 20 screenshots, i did reproduce the bug.. it seems that we can't trust the repaint event is on sync with the composite image, i found that @richardgv, the compton dev, advice to increase the delay in escrotum.. chjj/compton#252 Maybe we should re add the delay, after the repaint, and maybe make it configurable, it seems that it's a race condition affected by the load and luck :P |
Yeah, I didn't really want to edit the source and maintain a custom PKGBUILD with a diff, and then you removed the delay anyway with your "fix" that didn't worked. 😛 Configurable delay I guess would work, just add a tiny bit more delay and it should never happen, although adding a delay is more of a workaround than a proper fix. |
again, re add the timeout, a little longer, but now configurable it's not a proper fix, but a workaround until we found a real solution see #15 (comment)
yeah, i know it's a workaround, but for now i don't have more ideas for a proper fix, can you try this? e916f6e |
@Brottweiler i merged it to master, been using it since yesterday, with compton, and have no issue so far |
Yeah, haven't noticed issues so far either. |
Welp, I just had the issue again. It feels wrong to just add more delay... |
Yeah, i don't like the idea of delay either.. i'm thinking on move away from gtk for the window creation and use xcffib, with that we should have more control of when the window is destroyed. Another workaround, i guess, is to disable compositing on the window so you only see simple borders. |
Maybe remove the delay, since it's not really a fix anyway, and just have compton users remove the "shadow" for now. |
Same error today, how would you go about removing this shadow @Brottweiler? |
To be honest I'm not quite sure how you do it haha. |
Haha, so I'm not alone. Well, the shadow's still there for me, but it doesn't seem to show up on the screenshot afterwards so that's close enough for me. Using glx backend with paint on overlay activated, all fading and shadows disabled. |
It's "random", sometimes you get the shadow in the screenshot and sometimes not. |
i guess that, for a workarround, we could disable the composite transparency on the window, and just use plain borders, like it does without a compositor |
commenting this should be enough to test: https://github.com/Roger/escrotum/blob/master/escrotum/main.py#L40-L42 |
Maybe the delay should be removed as well then, to take the screenshot the On Tue, May 26, 2015, 19:12 Roger [email protected] wrote:
|
Seems to work for me, even with the delayed left enabled, it's fast enough for me |
Yeah, but the delay is pointless now so might aswell remove it. 😛 |
How about inverting the selection? Make everything darker and have a clear rectangle. |
@Zod- that could work, but we should rewrite selection using a fullscreen window, and cut a hole using cairo |
Getting this for ~40% of my screenshots now which is particularly annoying when I only find out hours later because my compton also blurs, making text unreadable. I assume excluding the window from shadows/blurring in my compton config would 'fix' it, but I'm not exactly sure how to target the window. Can anyone help with this? I also do really like the proposed solution of inverting the selection. I feel that would make more sense anyway. Not sure how difficult this would be, but I might be able to have a look in a few weeks. EDIT: the delay flag is not a viable workaround because it expects an integer, and waiting one second is way too much of a delay. |
Any news on this? |
Hi
I run openbox with compton. When I use escrotum to select a region with a mouse, the screenshot is dark.
Please see here http://aanatoly.github.io/ndnd/
My guess is this: escrotum opens a transparent window, compton adds a shadow and draws it onto root window, escrotum grabs a region from root window. So closing escrotum window before taking the shot may solve this
The text was updated successfully, but these errors were encountered: