Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript definitions #180

Open
larshp opened this issue Sep 24, 2021 · 2 comments
Open

typescript definitions #180

larshp opened this issue Sep 24, 2021 · 2 comments

Comments

@larshp
Copy link
Contributor

larshp commented Sep 24, 2021

Hi,
Are you interested in a PR that builds typescript definitions for this project?

The automatic generation of types from Javascript was introduced in https://devblogs.microsoft.com/typescript/announcing-typescript-3-7/#declaration-and-allowjs

Automatic generation is not perfect, but its a quick win, much better than nothing

A PR could look much like micromatch/picomatch#53
@larshp larshp mentioned this issue Sep 24, 2021
Closed
@larshp
Copy link
Contributor Author

larshp commented Apr 15, 2022

any thoughts?

@jeffalbion
Copy link
Collaborator

We welcome any PRs from the community that would help improve the driver: TypeScript support is certainly a welcome addition.

Our development team is mainly focused on enhancements for existing SAP applications using this driver moving to HANA Cloud so it is not likely we will get to this enhancement soon, but it is on our backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffalbion @larshp