Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum number of tasks in sequencer not triggering an error #52

Open
KaDw opened this issue Nov 13, 2022 · 1 comment
Open

Maximum number of tasks in sequencer not triggering an error #52

KaDw opened this issue Nov 13, 2022 · 1 comment
Assignees
Labels
internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system lorawan LoraWAN-related issue or pull-request.

Comments

@KaDw
Copy link

KaDw commented Nov 13, 2022

Setup:

  • LoRa-E5-STM32WLE5JC
  • GNU Arm Embedded Toolchain 10.3-2021.10

Bug:
Preprocessor error is not triggered if the CFG_SEQ_Task_NBR is > 32 although there is a code to protect it

#if UTIL_SEQ_CONF_TASK_NBR > 32
#error "UTIL_SEQ_CONF_PRIO_NBR must be less of equal then 32"
#endif

It happens because the #define UTIL_SEQ_CONF_TASK_NBR CFG_SEQ_Task_NBR is evaluated by preprocessor to zero. It doesn't know the value of CFG_SEQ_Task_NBR at this stage. Try to add -Wundef flag and see the compiler output

Next when there is a preprocessor macro #if UTIL_SEQ_CONF_TASK_NBR > 32 we copmare 0 > 32

Also there is a typo in the error message: UTIL_SEQ_CONF_TASK_NBR must be less of equal then 32

@ALABSTM ALABSTM added the lorawan LoraWAN-related issue or pull-request. label Feb 8, 2023
@ASELSTM
Copy link
Contributor

ASELSTM commented Jul 11, 2023

ST Internal Reference: 157070

@ASELSTM ASELSTM added the internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system label Jul 11, 2023
@ASELSTM ASELSTM moved this from To do to In progress in stm32cube-mcu-fw-dashboard Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system lorawan LoraWAN-related issue or pull-request.
Projects
Development

No branches or pull requests

4 participants