Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent GUI paints from blocking proxy activity and vice-versa #22

Open
SaladDais opened this issue Dec 4, 2021 · 0 comments
Open

Prevent GUI paints from blocking proxy activity and vice-versa #22

SaladDais opened this issue Dec 4, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@SaladDais
Copy link
Owner

Right now all code other than the mitmproxy wrapper runs in the same process and thread. This leads to issues where GUI paints can block proxy activity and vice-versa, mostly noticeable when a lot of messages are being logged at once.

On the one hand I don't normally notice the perf hit, and having everything on one thread allows writing relatively simple GUI code for addons without needing to use signals / slots (like the blueish object list.) On the other hand, a few people have told me that they disable the message log for perf reasons.

In the short term, it'd make sense to batch up additions to the message log list and only try to draw every 0.1 seconds, like we did before.

Longer-term, I'll have to come up with cross-thread implementations of the AddonManager.UI APIs using signals and slots, and figure out how to run UIs like the blueish object list in the UI thread.

@SaladDais SaladDais added the enhancement New feature or request label Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant