Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using pickle for serializing test data #37

Open
marcoheisig opened this issue Apr 4, 2023 · 0 comments
Open

Stop using pickle for serializing test data #37

marcoheisig opened this issue Apr 4, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@marcoheisig
Copy link
Collaborator

The test suite creates fixtures using pickle.load. This creates hard-coded dependencies to the libraries that were being used when those pickle files were created. The result is that the test suite randomly fails when we use newer libraries, like this:

https://github.com/SandoghdarLab/PiSCAT/actions/runs/4606677611/jobs/8140277049?pr=36#step:6:64

This should be fixed, so that PiSCAT can be used on more than just a narrow set of libraries.

@marcoheisig marcoheisig added the bug Something isn't working label Apr 4, 2023
@marcoheisig marcoheisig self-assigned this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant