-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDESystem Internal System Compatibility #2299
Comments
@xtalax we should make sure it's supported or throw |
Any update on this? I'm trying to implement @ChrisRackauckas 's ADS Paper via MTK & the new (great work btw!) ModelingToolkitNeuralNets.NeuralNetworkBlock and I suspect I hit the same issue (code snippet below). I guess I'll have to discretize by hand for now ? Or did you find a workaround @jbiffl ? Also: Happy to draft a PR if someone can provide me me with an overview of what needs to be changed (maybe @xtalax ? ) Example:
|
I'm not sure how this issue is related to doing UDEs with MethodOfLines.jl (and this reply seems to be on the wrong repo?). It's something we need to work on but I wouldn't expect MOL to handle it right now. |
The definition for a PDESystem includes a field for internal systems, (PDESystem · ModelingToolkit.jl) but it looks like discretization of the PDESystem does not look at these systems, causing errors when discretization is attempted. From what I can tell, the equations, variables, and parameters from these internal systems are not pulled into the main PDESystem in the way that they are for ODESystems on system definition from eqs, ivs, dvs, etc.
ODESystem(eqs, t, vars, pars; systems = [sys])
vs
PDESystem(eqs, bcs, domains, [ivs], [dvs], pars; systems = [sys])
Currently, the only reference to PDESystem.systems that I can find is in Give PDESystem a systems field by xtalax · Pull Request #1588 · SciML/ModelingToolkit.jl · GitHub which seems related to visualization.
The text was updated successfully, but these errors were encountered: