Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace should be consistent #693

Open
AsakusaRinne opened this issue Apr 24, 2024 · 2 comments
Open

Namespace should be consistent #693

AsakusaRinne opened this issue Apr 24, 2024 · 2 comments
Assignees

Comments

@AsakusaRinne
Copy link
Collaborator

Due to my neglection, the main package LLamaSharp uses the root namespace LLama but LLamaSharp.semantic-kernel and LLamaSharp.kernel-memory are using LLamaSharp.

We should take a good timepoint to refactor it to keep the namespace consistent, maybe in the next major release (1.0.0).

@AsakusaRinne AsakusaRinne self-assigned this Apr 28, 2024
@martindevans
Copy link
Member

Which one should we change? Changing the main package to LLamaSharp is more consistent, but is the bigger impact change.

@AsakusaRinne
Copy link
Collaborator Author

AsakusaRinne commented Jun 26, 2024

In my opinion we should use the LLama namespace everywhere. Though LLamaSharp is more suitable, changing it will impact too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 TODO
Development

No branches or pull requests

2 participants