Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type AdvancedOptions in Shipment #213

Open
Harasz opened this issue Jun 5, 2023 · 1 comment
Open

Wrong type AdvancedOptions in Shipment #213

Harasz opened this issue Jun 5, 2023 · 1 comment

Comments

@Harasz
Copy link

Harasz commented Jun 5, 2023

Hello,
I notice that interface AdvancedOptions has property dryIceWeight required while all others properties are optional. I think this is incorrect, especially when all comments says that those all options are optional.
@Harasz Harasz changed the title Wrong type AdvancedOptions in Shipment Wrong type AdvancedOptions in Shipment Jun 5, 2023
@jejrthompson
Copy link

I second this. It's making the Saturday delivery option unusable without specifying a dry ice weight. Even using dry ice weight of 0 lbs. throws the rate results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jejrthompson @Harasz