Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipment rates params type for ShipmentParam.Shipment.AdvancedOptions.BillToAccount appears to be incorrect #230

Open
kyle-villeneuve opened this issue Apr 11, 2024 · 0 comments

Comments

@kyle-villeneuve
Copy link
Contributor

get-rates-with-shipment-details/types/public-params.d.ts

declare type BillToAccount = "bill_to_country_code" | "bill_to_party" | "bill_to_postal_code";

In the example request here the following payload is used

"advanced_options": {
      "bill_to_account": "123456789",
      "bill_to_country_code": "US",
      "bill_to_party": "third_party",
      "bill_to_postal_code": "78756"
}

which if the type was accurate I wouldn't expect bill_to_account: "123456789" to be a valid rate request.

@kyle-villeneuve kyle-villeneuve changed the title Shipment rates params type for ShipmentParam.Shipment.AdvancedOptions.BillToAccount appear to be incorrect Shipment rates params type for ShipmentParam.Shipment.AdvancedOptions.BillToAccount appears to be incorrect Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant