Skip to content

refactor: remove unneeded function #97

refactor: remove unneeded function

refactor: remove unneeded function #97

Triggered via push June 26, 2024 09:34
Status Failure
Total duration 15s
Artifacts

rust-fmt.yml

on: push
Run rustfmt style commit
5s
Run rustfmt style commit
Fit to window
Zoom out
Zoom in

Annotations

13 warnings
Run rustfmt style commit
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, stefanzweifel/git-auto-commit-action@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
clamp-like pattern without using clamp function: src/net/live_fluereflow.rs#L147
warning: clamp-like pattern without using clamp function --> src/net/live_fluereflow.rs:147:36 | 147 | let progress = (last_export_guard.elapsed().as_millis() as f64 | ____________________________________^ 148 | | / interval as f64) 149 | | .min(1.0) 150 | | .max(0.0); | |_________________________________^ help: replace with clamp: `(last_export_guard.elapsed().as_millis() as f64 / interval as f64).clamp(0.0, 1.0)` | = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() = note: clamp returns NaN if the input is NaN = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp = note: `#[warn(clippy::manual_clamp)]` on by default
this function has too many arguments (27/7): fluereflow/src/types/fluereflow.rs#L63
warning: this function has too many arguments (27/7) --> fluereflow/src/types/fluereflow.rs:63:5 | 63 | / pub fn new( 64 | | source: IpAddr, 65 | | destination: IpAddr, 66 | | d_pkts: u32, ... | 90 | | tos: u8, 91 | | ) -> FluereRecord { | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
returning the result of a `let` binding from a block: fluere-config/src/init.rs#L98
warning: returning the result of a `let` binding from a block --> fluere-config/src/init.rs:98:5 | 97 | let path_config = path_base.join("fluere"); | ------------------------------------------- unnecessary `let` binding 98 | path_config | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 97 ~ 98 ~ path_base.join("fluere") |
unneeded unit expression: fluere-config/src/init.rs#L25
warning: unneeded unit expression --> fluere-config/src/init.rs:25:21 | 25 | () | ^^ help: remove the final `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default
clamp-like pattern without using clamp function: src/net/live_fluereflow.rs#L147
warning: clamp-like pattern without using clamp function --> src/net/live_fluereflow.rs:147:36 | 147 | let progress = (last_export_guard.elapsed().as_millis() as f64 | ____________________________________^ 148 | | / interval as f64) 149 | | .min(1.0) 150 | | .max(0.0); | |_________________________________^ help: replace with clamp: `(last_export_guard.elapsed().as_millis() as f64 / interval as f64).clamp(0.0, 1.0)` | = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() = note: clamp returns NaN if the input is NaN = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp = note: `#[warn(clippy::manual_clamp)]` on by default
this function has too many arguments (27/7): fluereflow/src/types/fluereflow.rs#L63
warning: this function has too many arguments (27/7) --> fluereflow/src/types/fluereflow.rs:63:5 | 63 | / pub fn new( 64 | | source: IpAddr, 65 | | destination: IpAddr, 66 | | d_pkts: u32, ... | 90 | | tos: u8, 91 | | ) -> FluereRecord { | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
returning the result of a `let` binding from a block: fluere-config/src/init.rs#L98
warning: returning the result of a `let` binding from a block --> fluere-config/src/init.rs:98:5 | 97 | let path_config = path_base.join("fluere"); | ------------------------------------------- unnecessary `let` binding 98 | path_config | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 97 ~ 98 ~ path_base.join("fluere") |
unneeded unit expression: fluere-config/src/init.rs#L25
warning: unneeded unit expression --> fluere-config/src/init.rs:25:21 | 25 | () | ^^ help: remove the final `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default
clamp-like pattern without using clamp function: src/net/live_fluereflow.rs#L147
warning: clamp-like pattern without using clamp function --> src/net/live_fluereflow.rs:147:36 | 147 | let progress = (last_export_guard.elapsed().as_millis() as f64 | ____________________________________^ 148 | | / interval as f64) 149 | | .min(1.0) 150 | | .max(0.0); | |_________________________________^ help: replace with clamp: `(last_export_guard.elapsed().as_millis() as f64 / interval as f64).clamp(0.0, 1.0)` | = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() = note: clamp returns NaN if the input is NaN = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp = note: `#[warn(clippy::manual_clamp)]` on by default
this function has too many arguments (27/7): fluereflow/src/types/fluereflow.rs#L63
warning: this function has too many arguments (27/7) --> fluereflow/src/types/fluereflow.rs:63:5 | 63 | / pub fn new( 64 | | source: IpAddr, 65 | | destination: IpAddr, 66 | | d_pkts: u32, ... | 90 | | tos: u8, 91 | | ) -> FluereRecord { | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
returning the result of a `let` binding from a block: fluere-config/src/init.rs#L98
warning: returning the result of a `let` binding from a block --> fluere-config/src/init.rs:98:5 | 97 | let path_config = path_base.join("fluere"); | ------------------------------------------- unnecessary `let` binding 98 | path_config | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 97 ~ 98 ~ path_base.join("fluere") |
unneeded unit expression: fluere-config/src/init.rs#L25
warning: unneeded unit expression --> fluere-config/src/init.rs:25:21 | 25 | () | ^^ help: remove the final `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default