Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series selection in previously opened mpReview processed directory #160

Open
che85 opened this issue Apr 25, 2017 · 3 comments
Open

Series selection in previously opened mpReview processed directory #160

che85 opened this issue Apr 25, 2017 · 3 comments

Comments

@che85
Copy link
Member

che85 commented Apr 25, 2017

mpReview should select the exact same series as selected by the user previously when reopening/reloading a mpReview processed directory instead of selecting the default over and over again.

TODO: need to think of a way to save it. Maybe we could have something like a directory specific json file which also could keep track of applied W/L values for latter loading

@fedorov Thoughts on this?

@fedorov
Copy link
Member

fedorov commented Apr 25, 2017

Yes, I think it makes sense to include a json file with this kind of data. I already had a JSON with W/L information some time ago. We should ask David if there is a mechanism in DICOM to store this kind of information.

I was also thinking it would make sense to have the functionality to assign "series type" in mpReview implemented similarly to how we tag series in SliceTracker. Perhaps the same set of components can be reused (automatic assignment of the series type, with the user having the capacity to re-assign via a drop-down), and the rules could be defined similarly. What do you think?

@che85
Copy link
Member Author

che85 commented Apr 25, 2017

Sounds good. What "series types" were you thinking of?

@fedorov
Copy link
Member

fedorov commented Apr 25, 2017

https://github.com/fedorov/mpReviewUtil/blob/master/SeriesNormalizer.py#L58

Turns out, I never cleaned up and integrated this ... We should discuss how much makes sense to do in mpReview, and what should be done for the PI-RADS workflow implementation. Need to think about this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants