Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize LUT labels between BWH and Chicago user groups #27

Open
fedorov opened this issue Apr 28, 2015 · 6 comments
Open

Harmonize LUT labels between BWH and Chicago user groups #27

fedorov opened this issue Apr 28, 2015 · 6 comments
Assignees

Comments

@fedorov
Copy link
Member

fedorov commented Apr 28, 2015

Need to make sure the default LUT currently used contains all the terms needed by the the Chicago group.

@rweiss42
Copy link
Collaborator

I went ahead and added the color table we came up with to the google doc. You'll notice when I created this table I spaced out the numbers to allow for future additions and to be sure that similar materials could appear together in the list (avoid how your Tumor_PZ_2 is far from your Tumor_PZ_3). Do you care that my numbers aren't sequential?

We could also designate chunks of the number space to different organizations. BWH could get domain over 1-100, uchicago 100-200, etc?

As we were discussing last time we spoke, the role of the number itself it less and less important these days since material name is tracked by file name.

@fedorov
Copy link
Member Author

fedorov commented Apr 29, 2015

for the reference, the LUT is here: http://goo.gl/7Rtgqp

@fedorov
Copy link
Member Author

fedorov commented Apr 29, 2015

Thank you Robin!

The motivation for this non-consecutive numbering is that our clinician didn't want to have a long list, and have most often used labels on top (not typical to have that many tumors). Also, we are hoping to mark some of the regions automatically (gland sectors), so they are in the middle, and then least likely numbers in the bottom.

Yes, as we discussed, the actual numbers and order are not so important. Material name is.

It's an interesting idea to have chunks of numbers for different organizations, but in a way it's procrastination :) What we need is agree that (for example) cancer_PZ_1 is the same as TumorROI_PZ_1, and get rid of the redundancy. Unless we do that, we won't be able (later on) to store the results in the standard fashion.

@rweiss42
Copy link
Collaborator

Makes sense. I just took another look at the list and I think cancer_PZ / TumorROI_PZ are the only place were our lists really overlap so I've changed that. I'm honestly not the domain expert here so for example I have no idea if *CGTZ would map to our *TZ.

Purely stylistic/non-important question: why do you have the substring ROI scattered around the label names? Aren't they all ROI's?

@fedorov
Copy link
Member Author

fedorov commented Apr 29, 2015

CGTZ will not map to TZ .... our clinical user didn't want to break down between the two, since it is hard to differentiate.

Re ROI - you are right, it is redundant, and the names are not consistent in that regard. I missed it and now I have to accept the consequences!

@fedorov
Copy link
Member Author

fedorov commented Jun 18, 2015

Robin, please let me know when you discussed this with Aytek, and then I will take over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants