Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x (next) release notes #117

Open
jcxldn opened this issue Mar 31, 2021 · 0 comments
Open

3.x (next) release notes #117

jcxldn opened this issue Mar 31, 2021 · 0 comments

Comments

@jcxldn
Copy link
Member

jcxldn commented Mar 31, 2021

  • Extend checkForUnresolvablePackages to also check "api" configuration
  • (:common project dependencies) Use api instead of implementation to also expose project dependencies at compile time

Fixes

  • When depending on stickyapi-bukkit or stickyapi-bungee only, stickyapi-common will now be available at both runtime and compile-time.
    • Previously, stickyapi-common was only availble at runtime, which causes compilation errors unless you also explicitly depended on stickyapi-common in your project.

compileClasspath before (explicit common dependency needed for compiletime)

+--- com.dumbdogdiner:stickyapi-bukkit:3.0.2
+--- com.dumbdogdiner:stickyapi-common:3.0.2
|    \--- com.dumbdogdiner:stickyapi-config:3.0.2

compileClasspath after (no explicit common dependency needed)

+--- com.dumbdogdiner:stickyapi-bukkit:3.X.X
|    \--- com.dumbdogdiner:stickyapi-common:3.X.X
|         \--- com.dumbdogdiner:stickyapi-config:3.X.X
@kaylendog kaylendog pinned this issue Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant