Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RowSpan does not work properly. #10

Open
spowner opened this issue Apr 13, 2018 · 1 comment
Open

RowSpan does not work properly. #10

spowner opened this issue Apr 13, 2018 · 1 comment
Assignees
Labels

Comments

@spowner
Copy link

spowner commented Apr 13, 2018

When using complex row and column spans in table form,
RowSpan does not work properly.

We have fixed the issue by modifying the following source code:

In PerformLayout ()

cellCount + = (ColumnDefinitions.Count! = 0)? Grid.GetColumnSpan (child): Grid.GetRowSpan (child);
cellCount + = (ColumnDefinitions.Count! = 0)? Grid.GetRowSpan (child) - 1: Grid.GetColumnSpan (child) - 1; // added (add RowSpan to cellCount)

...

Enumerable.Range (1, rowSpan) .ToList () ... // before
Enumerable.Range (1, rowSpan - 1) .ToList () ... // after

...

Enumerable.Range (1, columnSpan) .ToList () ... // before
Enumerable.Range (1, columnSpan - 1) .ToList () ... // after

...

This change works well.

I usually write well. Thank you.

@kmcginnes kmcginnes self-assigned this Apr 13, 2018
@kmcginnes kmcginnes added the bug label Apr 13, 2018
@kmcginnes
Copy link
Collaborator

I'll have to write a test around this scenario. Can you describe your layout in more detail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants