Skip to content

Latest commit

 

History

History
42 lines (31 loc) · 2.3 KB

CONTRIBUTING.md

File metadata and controls

42 lines (31 loc) · 2.3 KB
Raw

Contributing Guide

Creating an Issue

Before creating an Issue for features/bugs/improvements please follow these steps:

  1. Search existing Issues before creating a new issue (has someone raised this already)
  2. If it doesn't exist create a new issue giving as much context as possible
  3. All issues are automatically given the label status: waiting for triage and are automatically locked so no comments can be made
  4. If you wish to work on the Issue once it has been triaged and label changed to status: ready for dev, please include this in your Issue description

Working on an Issue (get it assigned to you)

Before working on an existing Issue please follow these steps:

  1. Only ask to be assigned 1 open issue at a time
  2. Look out for the Issue label status: ready for dev
  3. Comment asking for the issue to be assigned to you.
  4. After the Issue is assigned to you, you can start working on it
  5. Only start working on this Issue (and open a Pull Request) when it has been assigned to you - this will prevent confusion, multiple people working on the same issue, and work not being used
  6. reference the Issue in your Pull Request (for example closes #123)

Notes:

  • check the Assignees box at the top of the page to see if the issue has been assigned to someone else before requesting this be assigned to you
  • if an Issue is unclear, ask questions to get more clarity before asking to have the Issue assigned to you
  • only request to be assigned an Issue if you know how to work on it
  • an Issue can be assigned to multiple people if you all agree to collaborate on the issue (the Pull Request can contain commits from different collaborators)
  • any Issues that have no activity after 2 weeks will be unassigned and re-assigned to someone else

Reviewing Pull Requests

We welcome everyone to review Pull Requests, it is a great way to learn, network, and support each other.

DOs

  • be kind and respectful
  • use inline comments to explain your suggestions
  • use inline suggestions to propose changes

DON'Ts

  • do not be rude, disrespectful, or aggressive
  • do not repeat feedback, this creates more noise than value (check the existing conversation), use GitHub reactions if you agree/disagree with a comment
  • do not blindly approve pull requests to improve your GitHub contributor's graph