Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename withDevice() to getDevice() #1

Open
Sternbach-Software opened this issue Dec 16, 2022 · 0 comments
Open

Rename withDevice() to getDevice() #1

Sternbach-Software opened this issue Dec 16, 2022 · 0 comments

Comments

@Sternbach-Software
Copy link
Owner

Sternbach-Software commented Dec 16, 2022 •
edited
Loading

It is more idiomatic to use get. Although withDevice accurately conveys that the actions like turnOn are simply forwarded to the API, get is more familiar.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sternbach-Software